Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using value_expr and assignable_expr analysis functions where appropriate. #493

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Using value_expr and assignable_expr analysis functions where appropriate. #493

merged 1 commit into from
Aug 3, 2021

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Jul 30, 2021 •
edited
Loading

What was wrong?

closes #491

How was it fixed?

Searched usages of expression::expr and fixed places where value_expr or assignable_expr needed to be used.

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021 •
edited
Loading

Codecov Report

Merging #493 (8046440) into master (9fc45b3) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

❗ Current head 8046440 differs from pull request most recent head 1882fad. Consider uploading reports for the commit 1882fad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   87.79%   87.75%   -0.05%     
==========================================
  Files          80       80              
  Lines        5268     5274       +6     
==========================================
+ Hits         4625     4628       +3     
- Misses        643      646       +3
Impacted Files Coverage Δ
crates/analyzer/src/traversal/expressions.rs 90.79% <45.45%> (-0.40%) ⬇️
crates/analyzer/src/traversal/functions.rs 91.12% <100.00%> (ø)
crates/analyzer/src/namespace/events.rs 88.57% <0.00%> (-5.72%) ⬇️
crates/analyzer/src/namespace/scopes.rs 93.88% <0.00%> (-1.12%) ⬇️
crates/yulgen/src/mappers/expressions.rs 90.19% <0.00%> (+0.19%) ⬆️
crates/analyzer/src/namespace/types.rs 76.44% <0.00%> (+0.41%) ⬆️
crates/parser/src/ast.rs 51.11% <0.00%> (+2.22%) ⬆️
crates/analyzer/src/lib.rs 90.90% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc45b3...1882fad. Read the comment docs.

@g-r-a-n-t g-r-a-n-t force-pushed the assignable-exprs branch 3 times, most recently from 1f6ad11 to b807131 Compare August 2, 2021 16:35
cburgdorf
cburgdorf approved these changes Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@cburgdorf cburgdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@g-r-a-n-t g-r-a-n-t merged commit 71a2430 into ethereum:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cburgdorf cburgdorf cburgdorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix places where assignable_expr should be used.
3 participants
@g-r-a-n-t @codecov-commenter @cburgdorf